dev: split ContextLoader #4516
Merged
dev: split ContextLoader #4516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
alexandear
approved these changes
Mar 16, 2024
Co-authored-by: Oleksandr Redko <[email protected]>
bombsimon
approved these changes
Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextLoaderwas an ambiguous name to hide that it was doing 2 things:The PR splits
ContextLoaderintoContextBuilderandPackageLoader:ContextBuilderbuilds a linter contextPackageLoaderloads packagesThere are no fundamental changes here, the goal is to ease maintenance.
Also, it removes the usage of
cfg.Run.Args.I will create another PR to remove completely the usage of
cfg.Run.Args.One commit, one change.